-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] partner_title_order: Migration to 18.0 #5
[18.0][MIG] partner_title_order: Migration to 18.0 #5
Conversation
Currently translated at 100.0% (5 of 5 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_title_order Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_title_order/fr/
Currently translated at 100.0% (5 of 5 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_title_order Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_title_order/es/
@@ -14,7 +14,7 @@ def test_default_order(self): | |||
partner_titles = self.env["res.partner.title"].search([]) | |||
self.assertEqual( | |||
partner_titles.mapped("name"), | |||
partner_titles.sorted(lambda x: x.name).mapped("name"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change because the test failed ?
Because it should not have, all sequence fields should have been set to 10 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good
@Kimkhoi3010 Could we move this to the oca repository, thank you |
No description provided.